fix(linux): check for existing file before trying to install #15573
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User Test Results |
keymanapp-test-bot
bot
added
has-user-test
user-test-required
Under some circumstances it's possible that the user manages to select a directory instead of a kmp file, or manually enters a non-existing file. Is used to throw an error that we caught on Sentry; the user was able to continue to use the app. This change now checks for a valid file before trying to install the kmp file. Fixes: #15572 Fixes: KEYMAN-LINUX-99
ermshiperete
force-pushed
the
fix/linux/15572_FileNotFoundError
branch
from
ef8990c to
7941b3d
Compare
mcdurdin
approved these changes
Feb 10, 2026
Contributor
Test Prerequisites
Test Specs
Test Results
|
keymanapp-test-bot
bot
removed
the
user-test-required
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.202-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some circumstances it's possible that the user manages to select a directory instead of a kmp file, or manually enters a non-existing file. Is used to throw an error that we caught on Sentry; the user was able to continue to use the app. This change now checks for a valid file before trying to install the kmp file.
Fixes: #15572
Fixes: KEYMAN-LINUX-99
User Testing
TEST_FIX:
km-configand click the "Install keyboard" button/homex, and click Open